FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is experimental
Effort is max
Summary
Classes | Bugs | Errors | Missing Classes |
---|
26 | 30 | 0 | 0 |
net.sf.openv4j.AccessType
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.DataPoint
Bug | Category | Details | Line | Priority |
---|
Method net.sf.openv4j.DataPoint.getFormatString() uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 689724727730 | 3 |
net.sf.openv4j.DataPoint.BLOCKS_16 should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 457 | 2 |
Suspicious comparison of Byte references in net.sf.openv4j.DataPoint.compareBytes(MemoryImage, int, int, int) | CORRECTNESS | RC_REF_COMPARISON | 537 | 1 |
net.sf.openv4j.DataType
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.Devices
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.ErrorListEntry
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.ErrorListEntry.getTinestamp() may expose internal representation by returning ErrorListEntry.tinestamp | MALICIOUS_CODE | EI_EXPOSE_REP | 64 | 2 |
new net.sf.openv4j.ErrorListEntry(int, Date) may expose internal representation by storing an externally mutable object into ErrorListEntry.tinestamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 | 2 |
net.sf.openv4j.ErrorListEntry.setTinestamp(Date) may expose internal representation by storing an externally mutable object into ErrorListEntry.tinestamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 82 | 2 |
net.sf.openv4j.Group
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.GroupAndNameComparator
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.GroupAndNameComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 14 | 2 |
net.sf.openv4j.Holiday
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.Holiday.getEnd() may expose internal representation by returning Holiday.end | MALICIOUS_CODE | EI_EXPOSE_REP | 46 | 2 |
net.sf.openv4j.Holiday.getStart() may expose internal representation by returning Holiday.start | MALICIOUS_CODE | EI_EXPOSE_REP | 64 | 2 |
net.sf.openv4j.Holiday.setEnd(Date) may expose internal representation by storing an externally mutable object into Holiday.end | MALICIOUS_CODE | EI_EXPOSE_REP2 | 82 | 2 |
net.sf.openv4j.Holiday.setStart(Date) may expose internal representation by storing an externally mutable object into Holiday.start | MALICIOUS_CODE | EI_EXPOSE_REP2 | 100 | 2 |
net.sf.openv4j.Property
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.PropertyType
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.Protocol
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.protocolhandlers.DataBlock
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.protocolhandlers.DataBlock.getBytes() may expose internal representation by returning DataBlock.data | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | 2 |
net.sf.openv4j.protocolhandlers.DataBlock.setBytesAtPos(int, byte[]) may expose internal representation by storing an externally mutable object into DataBlock.data | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | 2 |
net.sf.openv4j.protocolhandlers.ProtocolHandler
Bug | Category | Details | Line | Priority |
---|
net.sf.openv4j.protocolhandlers.ProtocolHandler.close() calls Thread.sleep() with a lock held | MT_CORRECTNESS | SWL_SLEEP_WITH_LOCK_HELD | 69 | 2 |
net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener
Bug | Category | Details | Line | Priority |
---|
Naked notify in net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.checkConnBroken(int, ProtocolHandler$State) | MT_CORRECTNESS | NN_NAKED_NOTIFY | 305 | 2 |
Naked notify in net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.dataReaded(int) | MT_CORRECTNESS | NN_NAKED_NOTIFY | 342 | 2 |
Naked notify in net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.dataWritten(int) | MT_CORRECTNESS | NN_NAKED_NOTIFY | 366 | 2 |
Exception is caught when Exception is not thrown in net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.run() | STYLE | REC_CATCH_EXCEPTION | 253 | 4 |
Switch statement found in net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.run() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 238 | 3 |
Private method net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.checkClosed(int) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 288 | 3 |
Unread field: net.sf.openv4j.protocolhandlers.ProtocolHandler$StreamListener.timeoutTimeStamp | PERFORMANCE | URF_UNREAD_FIELD | 263 | 2 |
net.sf.openv4j.protocolhandlers.SimpleDataContainer
Bug | Category | Details | Line | Priority |
---|
Format-string method String.format(String, Object[]) called with format string "0x04x :" wants 0 arguments but is given 1 in net.sf.openv4j.protocolhandlers.SimpleDataContainer.toString() | CORRECTNESS | VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED | 146 | 1 |